Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-578] add review component field #592

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

lambry
Copy link

@lambry lambry commented Feb 10, 2025

Jira

https://digital-vic.atlassian.net/browse/SD-578
Testing link: https://nginx-php.pr-1805.content-vic.sdp4.sdp.vic.gov.au/

Problem/Motivation

The frontend needed a new placeholder field to allow for a review component to be inserted in the correct location.

Fix

Adds a new webform field that acts placeholder, meaning it doesn't need all the extra field options that other fields have.

Screenshots

Screenshot 2025-02-10 at 5 01 34 pm Screenshot 2025-02-10 at 5 03 01 pm

Hey @anthony-malkoun @yeniatencio, does this need a test? I could look at adding a test for a multistep/wizard form that includes this. Also, I don't have any contextual knowledge here so please let me know if I've missed anything and or done anything incorrectly. Thanks

@lambry lambry self-assigned this Feb 10, 2025
@anthony-malkoun
Copy link
Contributor

Hey @lambry could this be extended to just be a "custom webform component", where review is a specific type? I think @dylankelly has some requirements around this that might make sense to roll in.

As for approach, I have no problem with this. @yeniatencio can you help David with tests?

@anthony-malkoun
Copy link
Contributor

(Also, as an aside, it's probably not a "Composite Element". Could probably get its own group, "Ripple Elements" or "Custom Elements" or just "Other" :) )

@lambry
Copy link
Author

lambry commented Feb 11, 2025

Thanks @anthony-malkoun,

Yeah happy to move it, I just placed it under composite as it'll display a bunch of fields like a composite.

Just to confirm, when you say "a 'custom webform component', where review is a specific type" we're talking about the element setting type here?
Screenshot 2025-02-11 at 2 38 01 pm

It'd be good to get a quick intro into things from yourself or @yeniatencio this week if either of you have time.

Cheers

@dylankelly
Copy link

dylankelly commented Feb 14, 2025

@lambry @anthony-malkoun this review component should be available to everyone that is setting up a multistep form, the intention is that someone like Jo will be adding these. The custom element with a config blob idea should be raised as a seperate issue

Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants