Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stream_family): Fix journaling in the XADD and XTRIM commands #4448

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(stream_family): Fix journaling in the XADD and XTRIM commands #4448

wants to merge 5 commits into from
+287 −150

Conversation

BagritsevichStepan
Copy link
Contributor

@BagritsevichStepan BagritsevichStepan commented Jan 13, 2025 •
edited
Loading

fixes #4202

  1. Fix journaling
  2. Clean up and refactor the parsing logic for the XADD and XTRIM commands

@BagritsevichStepan BagritsevichStepan self-assigned this Jan 13, 2025
@BagritsevichStepan BagritsevichStepan force-pushed the stream/fix-trim-journaling branch from 2ddf4cc to f635b6a Compare January 21, 2025 10:28
adiholden
adiholden reviewed Jan 27, 2025
View reviewed changes
tests/dragonfly/replication_test.py
await asyncio.sleep(1)

# Check replica data consistent
master_data = await StaticSeeder.capture(c_master)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that that static seeder does not work on stream type, see class StaticSeeder impl
also we do not have the hash funciton for stream type in script-hashlib.lua
you will need to add this functionality
Please make a separate PR for this change and validate the static seeder capture finds fails if there is a diff by temporary inserting a bug to replication code of streams

BorysTheDev
BorysTheDev reviewed Jan 27, 2025
View reviewed changes
src/redis/t_stream.c Outdated Show resolved Hide resolved
BorysTheDev
BorysTheDev reviewed Jan 27, 2025
View reviewed changes
src/redis/t_stream.c Outdated Show resolved Hide resolved
@BagritsevichStepan BagritsevichStepan force-pushed the stream/fix-trim-journaling branch from f635b6a to d8282a2 Compare February 4, 2025 10:25
@BagritsevichStepan
refactor: address comments 2
81bec73 
Signed-off-by: Stepan Bagritsevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiholden adiholden adiholden left review comments

@romange romange romange left review comments

@BorysTheDev BorysTheDev BorysTheDev approved these changes

Assignees

@BagritsevichStepan BagritsevichStepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

streams XADD/XTRIM require journal rewrite during the replication
4 participants
@BagritsevichStepan @romange @BorysTheDev @adiholden