fix(search_family): Add options test for the FT.AGGREGATE command #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
BagritsevichStepan
force-pushed
the
search/ft-aggregate-add-option-tests
branch
from
e1d3c11 to
3570612
Compare
BorysTheDev
reviewed
Jan 31, 2025
| @@ -119,7 +119,7 @@ struct CmdArgParser { | |||
|
|
|||
| // Check if the next value is equal to a specific tag. If equal, its consumed. | |||
| template <class... Args> bool Check(std::string_view tag, Args*... args) { | |||
| if (cur_i_ + sizeof...(Args) >= args_.size()) | |||
| if (cur_i_ + sizeof...(Args) >= args_.size() || error_) | |||
There was a problem hiding this comment.
I think that if an error occurred previously during parsing, why are we still returning true for parser->Check("TAG"), for example? It should simply skip all checks
BorysTheDev
reviewed
Jan 31, 2025
BorysTheDev
reviewed
Jan 31, 2025
BorysTheDev
reviewed
Jan 31, 2025
BorysTheDev
reviewed
Jan 31, 2025
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
search/ft-aggregate-add-option-tests
branch
from
3570612 to
4926c1d
Compare
Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
search/ft-aggregate-add-option-tests
branch
from
4926c1d to
a047d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to the #4204
It was a bad decision to use it because, in some cases, we were returning an error with
builder->SendError(...). However, in those cases, we were not handling parser errors withparser->Error(). As a result, debug builds were crashing because of this check:Now, we ensure that parsing errors are processed in all cases.
3. Add options test for the
FT.AGGREGATEcommand