-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(search_family): Add options test for the FT.AGGREGATE command #4479
fix(search_family): Add options test for the FT.AGGREGATE command #4479
Conversation
e1d3c11
to
3570612
Compare
3570612
to
4926c1d
Compare
4926c1d
to
a047d47
Compare
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
a047d47
to
9dea4fd
Compare
if (!parse_result.value()) { | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
For ParseSchema
, we return false. It is the last option that should be parsed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you already have a check if (!parse_result) so parse_result.value() is always exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parse_result is io::Error<bool>
, so when I prove if (!parse_result)
, I prove that no error occurred. When I check if (!parse_result.value())
, I prove that the returned result is false.
related to the #4204
It was a bad decision to use it because, in some cases, we were returning an error with
builder->SendError(...)
. However, in those cases, we were not handling parser errors withparser->Error()
. As a result, debug builds were crashing because of this check:Now, we ensure that parsing errors are processed in all cases.
3. Add options test for the
FT.AGGREGATE
command