chore: implement sharded pub/sub #4518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Jan 28, 2025
|
|
||
| // Sharded pub sub | ||
| // Command form: SPUBLISH shardchannel message | ||
| if (cid->name() == "SPUBLISH") { |
There was a problem hiding this comment.
We need to bypass DetermineKeys only for this specific case.
Signed-off-by: kostas <[email protected]>
kostasrim
commented
Jan 28, 2025
| FLAGS_fiber_safety_margin=4096 FLAGS_list_experimental_v2=true timeout 20m ctest -V -L DFLY | ||
| FLAGS_fiber_safety_margin=4096 FLAGS_list_experimental_v2=true timeout 20m ctest -V -L DFLY -E allocation_tracker | ||
|
|
||
| # Run allocation tracker test separately. It generates a TON of logs |
There was a problem hiding this comment.
Allocation tracker test generates a gazillion number of logs. I silenced it that way by excluding the test from running with alsologtostderr flag.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3001 by adding the basic functionality for sharded pub/sub for Dragonfly cluster.
What's left for sharded pub sub is described in #4517 but the gist is that we need to evict subscribed connections after a slot migration. This will be added in a follow up PR.