chore: Add suffix and infix search syntax support in query parser #5091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
May 9, 2025
romange
reviewed
May 9, 2025
romange
reviewed
May 11, 2025
src/core/search/search.cc
Outdated
| @@ -118,19 +118,27 @@ struct ProfileBuilder { | |||
| string GetNodeInfo(const AstNode& node) { | |||
| struct NodeFormatter { | |||
| void operator()(std::string* out, const AstPrefixNode& node) const { | |||
There was a problem hiding this comment.
you can write here: template <TagType T> void operator()(std::string* out, const AstAffixNode<T>& node)
to avoid code duplication
romange
reviewed
May 11, 2025
| EXPECT_EQ(1, Parse("*pre")); | ||
| EXPECT_EQ(1, Parse("*pre*")); | ||
| EXPECT_EQ(0, Parse("*suffix")); | ||
| EXPECT_EQ(0, Parse("*infix")); |
There was a problem hiding this comment.
It should be infix
romange
reviewed
May 11, 2025
romange
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds syntax parsing support for suffix (*term) and infix (*term*) search patterns. While the actual search implementation remains placeholder, this PR establishes the full parsing pipeline from lexer/parser through to AST nodes and query execution.
The foundation is now in place for future implementation of the actual search algorithms.
Related issues: