Upgrade rpm dependency to 0.14 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized I could've just disabled default features as I don't rely on PGP at the moment 🤦 But wouldn't hurt I guess. I also see some weird behavior when "bstr" is introduced to the dependency tree (related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
[email protected] has a dependency which doesn't seem to work on Mac. Tried some dependency patching but that didn't seem to work as I expected. I got a conflicting version request for a pgp dependency this time which stemmed from rpmrepo_metadata's dependency on rpm (I have to admit that I'm new to dependency consolidation with Cargo).
Upgrading to 0.14 seemed to work and tests were passing so thought it might be a good idea to do an upgrade here