Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cf): fix cf custom formula range change #4381

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Dec 28, 2024

close https://github.com/dream-num/univer-pro/issues/3013

条件格式所有有公式的地方都要受到删除行列等操作造成的选区改变, 测的时候帮忙再稍微点点条件格式的功能 看有没有哪里受到影响,包括撤消重做也帮忙走一走

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Dec 28, 2024
@wpxp123456 wpxp123456 requested a review from Gggpound as a code owner December 28, 2024 06:18
Copy link

github-actions bot commented Dec 28, 2024

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@univer-bot
Copy link

univer-bot bot commented Dec 28, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(cf): fix cf custom formula range change

Title: fix(cf): fix cf custom formula range change


close https://github.com/dream-num/univer-pro/issues/3013

All places with formulas in conditional formatting will be affected by selection changes caused by operations such as deleting rows and columns. When testing, please help me check out the function of conditional formatting to see if anything is affected, including undoing and redoing, and also help me walk through it.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 28, 2024

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 6 seconds
commit  d6636ba
info  For more information, see full report

@wpxp123456 wpxp123456 removed the qa:untested This PR is ready to be tested label Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 93 lines in your changes missing coverage. Please review.

Project coverage is 34.06%. Comparing base (039ec12) to head (d6636ba).

Files with missing lines Patch % Lines
...ting-ui/src/controllers/cf.ref-range.controller.ts 0.00% 93 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4381      +/-   ##
==========================================
- Coverage   34.08%   34.06%   -0.03%     
==========================================
  Files        2628     2628              
  Lines      137176   137267      +91     
  Branches    30451    30478      +27     
==========================================
  Hits        46762    46762              
- Misses      90414    90505      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Dec 28, 2024
}
undoMap[`${unitId}_${subUnitId}_${cfId}`].push(item.params as ISetConditionalRuleMutationParams);
});
Object.values(undoMap).forEach((paramsList) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo 不需要处理么?

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are required for this PR, as this PR introduces an important and error-prone change.

@zhaolixin7
Copy link

@univer-bot
Copy link

univer-bot bot commented Feb 17, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@wpxp123456 After custom formula deletes some selections
https://github.com/user-attachments/assets/99b0d0a1-88a3-4927-9351-1b54f4cde6f0

@wpxp123456 wpxp123456 force-pushed the pxp/12271723 branch 2 times, most recently from 1f816c3 to 67319b8 Compare February 28, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants