Merge pull request #385 from drewnoakes/warn-as-error

Treat warnings as errors
drewnoakes · Jan 29, 2024 · 35a2601 · 35a2601
2 parents 5664056 + 9ab0c16
commit 35a2601
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 14 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -5,6 +5,7 @@
     <DebugType>portable</DebugType>
     <LangVersion>preview</LangVersion>
     <Nullable>enable</Nullable>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <Authors>Drew Noakes</Authors>
     <Copyright>Copyright Drew Noakes 2002-2023</Copyright>
     <PackageIcon>metadata-extractor-logo-128.png</PackageIcon>

diff --git a/MetadataExtractor/PublicAPI/net462/PublicAPI.Shipped.txt b/MetadataExtractor/PublicAPI/net462/PublicAPI.Shipped.txt
@@ -1768,7 +1768,6 @@ const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImage = 1
 const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImageHeight = 4 -> int
 const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImageType = 34 -> int
 const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImageWidth = 2 -> int
-static MetadataExtractor.Formats.Flir.FlirReader.JpegSegmentPreamble.get -> System.ReadOnlySpan<byte>
 const MetadataExtractor.Formats.GeoTiff.GeoTiffDirectory.TagChartContourInterval = 47017 -> int
 const MetadataExtractor.Formats.GeoTiff.GeoTiffDirectory.TagChartCorrDate = 47005 -> int
 const MetadataExtractor.Formats.GeoTiff.GeoTiffDirectory.TagChartCountryOrigin = 47006 -> int

diff --git a/MetadataExtractor/PublicAPI/net462/PublicAPI.Unshipped.txt b/MetadataExtractor/PublicAPI/net462/PublicAPI.Unshipped.txt
@@ -1,5 +1,4 @@
 #nullable enable
-abstract MetadataExtractor.Formats.Riff.RiffHandler.ShouldAcceptRiffIdentifier(System.ReadOnlySpan<byte> identifier) -> bool
 abstract MetadataExtractor.IO.IndexedReader.GetByteInternal(int index) -> byte
 abstract MetadataExtractor.IO.SequentialReader.GetBytes(System.Span<byte> bytes) -> void
 const MetadataExtractor.Formats.Exif.Makernotes.AppleRunTimeMakernoteDirectory.TagEpoch = 2 -> int
@@ -47,7 +46,6 @@ MetadataExtractor.Formats.Apple.BplistReader.BplistReader() -> void
 MetadataExtractor.Formats.Apple.BplistReader.PropertyListResults
 MetadataExtractor.Formats.Apple.BplistReader.PropertyListResults.Get(byte key) -> object!
 MetadataExtractor.Formats.Apple.BplistReader.PropertyListResults.GetTopObject() -> System.Collections.Generic.Dictionary<byte, byte>?
-MetadataExtractor.Formats.Avi.AviRiffHandler.ShouldAcceptRiffIdentifier(System.ReadOnlySpan<byte> identifier) -> bool
 MetadataExtractor.Formats.Exif.Makernotes.AppleRunTimeMakernoteDescriptor
 MetadataExtractor.Formats.Exif.Makernotes.AppleRunTimeMakernoteDescriptor.AppleRunTimeMakernoteDescriptor(MetadataExtractor.Formats.Exif.Makernotes.AppleRunTimeMakernoteDirectory! directory) -> void
 MetadataExtractor.Formats.Exif.Makernotes.AppleRunTimeMakernoteDescriptor.GetFlagsDescription() -> string?
@@ -69,17 +67,13 @@ MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl2Descriptor.GetToni
 MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl2Descriptor.NikonPictureControl2Descriptor(MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl2Directory! directory) -> void
 MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl2Directory
 MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl2Directory.NikonPictureControl2Directory() -> void
-MetadataExtractor.Formats.Riff.IRiffHandler.ShouldAcceptRiffIdentifier(System.ReadOnlySpan<byte> identifier) -> bool
-MetadataExtractor.Formats.WebP.WebPRiffHandler.ShouldAcceptRiffIdentifier(System.ReadOnlySpan<byte> identifier) -> bool
 MetadataExtractor.IO.IndexedReader.GetByte(int index) -> byte
-MetadataExtractor.KeyValuePair.KeyValuePair() -> void
 override MetadataExtractor.Formats.Exif.Makernotes.AppleRunTimeMakernoteDescriptor.GetDescription(int tagType) -> string?
 override MetadataExtractor.Formats.Exif.Makernotes.AppleRunTimeMakernoteDirectory.Name.get -> string!
 override MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl1Descriptor.GetDescription(int tagType) -> string?
 override MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl1Directory.Name.get -> string!
 override MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl2Descriptor.GetDescription(int tagType) -> string?
 override MetadataExtractor.Formats.Exif.Makernotes.NikonPictureControl2Directory.Name.get -> string!
-override MetadataExtractor.Formats.Wav.WavRiffHandler.ShouldAcceptRiffIdentifier(System.ReadOnlySpan<byte> identifier) -> bool
 override MetadataExtractor.IO.ByteArrayReader.GetByteInternal(int index) -> byte
 override MetadataExtractor.IO.IndexedSeekingReader.GetByteInternal(int index) -> byte
 override MetadataExtractor.IO.SequentialByteArrayReader.GetBytes(System.Span<byte> bytes) -> void

diff --git a/MetadataExtractor/PublicAPI/netstandard1.3/PublicAPI.Shipped.txt b/MetadataExtractor/PublicAPI/netstandard1.3/PublicAPI.Shipped.txt
@@ -1768,7 +1768,6 @@ const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImage = 1
 const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImageHeight = 4 -> int
 const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImageType = 34 -> int
 const MetadataExtractor.Formats.Flir.FlirRawDataDirectory.TagRawThermalImageWidth = 2 -> int
-static MetadataExtractor.Formats.Flir.FlirReader.JpegSegmentPreamble.get -> System.ReadOnlySpan<byte>
 const MetadataExtractor.Formats.GeoTiff.GeoTiffDirectory.TagChartContourInterval = 47017 -> int
 const MetadataExtractor.Formats.GeoTiff.GeoTiffDirectory.TagChartCorrDate = 47005 -> int
 const MetadataExtractor.Formats.GeoTiff.GeoTiffDirectory.TagChartCountryOrigin = 47006 -> int

diff --git a/MetadataExtractor/PublicAPI/netstandard2.1/PublicAPI.Shipped.txt b/MetadataExtractor/PublicAPI/netstandard2.1/PublicAPI.Shipped.txt
@@ -276,7 +276,6 @@ const MetadataExtractor.Formats.Exif.ExifDirectoryBase.TagYCbCrSubsampling = 530
 const MetadataExtractor.Formats.Exif.ExifDirectoryBase.TagYResolution = 283 -> int
 const MetadataExtractor.Formats.Exif.ExifIfd0Directory.TagExifSubIfdOffset = 34665 -> int
 const MetadataExtractor.Formats.Exif.ExifIfd0Directory.TagGpsInfoOffset = 34853 -> int
-const MetadataExtractor.Formats.Exif.ExifReader.JpegSegmentPreamble = "Exif\0\0" -> string!
 const MetadataExtractor.Formats.Exif.ExifSubIfdDirectory.TagInteropOffset = 40965 -> int
 const MetadataExtractor.Formats.Exif.ExifThumbnailDirectory.TagThumbnailLength = 514 -> int
 const MetadataExtractor.Formats.Exif.ExifThumbnailDirectory.TagThumbnailOffset = 513 -> int
@@ -1953,7 +1952,6 @@ const MetadataExtractor.Formats.Icc.IccDirectory.TagTag_KTrc = 1800688195 -> int
 const MetadataExtractor.Formats.Icc.IccDirectory.TagTag_RTrc = 1918128707 -> int
 const MetadataExtractor.Formats.Icc.IccDirectory.TagTag_RXyz = 1918392666 -> int
 const MetadataExtractor.Formats.Icc.IccDirectory.TagXyzValues = 68 -> int
-const MetadataExtractor.Formats.Icc.IccReader.JpegSegmentPreamble = "ICC_PROFILE" -> string!
 const MetadataExtractor.Formats.Ico.IcoDirectory.TagBitsPerPixel = 7 -> int
 const MetadataExtractor.Formats.Ico.IcoDirectory.TagColourPaletteSize = 4 -> int
 const MetadataExtractor.Formats.Ico.IcoDirectory.TagColourPlanes = 5 -> int
@@ -2047,9 +2045,7 @@ const MetadataExtractor.Formats.Jfif.JfifDirectory.TagThumbHeight = 13 -> int
 const MetadataExtractor.Formats.Jfif.JfifDirectory.TagThumbWidth = 12 -> int
 const MetadataExtractor.Formats.Jfif.JfifDirectory.TagUnits = 7 -> int
 const MetadataExtractor.Formats.Jfif.JfifDirectory.TagVersion = 5 -> int
-const MetadataExtractor.Formats.Jfif.JfifReader.JpegSegmentPreamble = "JFIF" -> string!
 const MetadataExtractor.Formats.Jfxx.JfxxDirectory.TagExtensionCode = 5 -> int
-const MetadataExtractor.Formats.Jfxx.JfxxReader.JpegSegmentPreamble = "JFXX" -> string!
 const MetadataExtractor.Formats.Jpeg.HuffmanTablesDirectory.TagNumberOfTables = 1 -> int
 const MetadataExtractor.Formats.Jpeg.JpegCommentDirectory.TagComment = 0 -> int
 const MetadataExtractor.Formats.Jpeg.JpegDirectory.TagComponentData1 = 6 -> int
@@ -2091,7 +2087,6 @@ const MetadataExtractor.Formats.Pcx.PcxDirectory.TagYMin = 4 -> int
 const MetadataExtractor.Formats.Photoshop.DuckyDirectory.TagComment = 2 -> int
 const MetadataExtractor.Formats.Photoshop.DuckyDirectory.TagCopyright = 3 -> int
 const MetadataExtractor.Formats.Photoshop.DuckyDirectory.TagQuality = 1 -> int
-const MetadataExtractor.Formats.Photoshop.DuckyReader.JpegSegmentPreamble = "Ducky" -> string!
 const MetadataExtractor.Formats.Photoshop.PhotoshopDirectory.TagAlphaChannels = 1006 -> int
 const MetadataExtractor.Formats.Photoshop.PhotoshopDirectory.TagAlphaIdentifiers = 1053 -> int
 const MetadataExtractor.Formats.Photoshop.PhotoshopDirectory.TagAlternateDuotoneColors = 1066 -> int
@@ -2180,7 +2175,6 @@ const MetadataExtractor.Formats.Photoshop.PhotoshopDirectory.TagWinDevmode = 108
 const MetadataExtractor.Formats.Photoshop.PhotoshopDirectory.TagWorkflowUrl = 1051 -> int
 const MetadataExtractor.Formats.Photoshop.PhotoshopDirectory.TagXml = 1002 -> int
 const MetadataExtractor.Formats.Photoshop.PhotoshopDirectory.TagXmpData = 1060 -> int
-const MetadataExtractor.Formats.Photoshop.PhotoshopReader.JpegSegmentPreamble = "Photoshop 3.0" -> string!
 const MetadataExtractor.Formats.Photoshop.PsdHeaderDirectory.TagBitsPerChannel = 4 -> int
 const MetadataExtractor.Formats.Photoshop.PsdHeaderDirectory.TagChannelCount = 1 -> int
 const MetadataExtractor.Formats.Photoshop.PsdHeaderDirectory.TagColorMode = 5 -> int