Fix length check in PngMetadataReader

drewnoakes · Feb 2, 2024 · 59f4294 · 59f4294
1 parent f4437f5
commit 59f4294
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/MetadataExtractor/Formats/Png/PngMetadataReader.cs b/MetadataExtractor/Formats/Png/PngMetadataReader.cs
@@ -332,17 +332,19 @@ private static IEnumerable<Directory> ProcessChunk(PngChunk chunk)
                 {
                     directory.AddError("Insufficient bytes for PNG pHYs chunk.");
                 }
+                else
+                {
+                    var reader = new BufferReader(bytes, isBigEndian: true);
 
-                var reader = new BufferReader(bytes, isBigEndian: true);
-
-                var pixelsPerUnitX = reader.GetInt32();
-                var pixelsPerUnitY = reader.GetInt32();
-                var unitSpecifier = reader.GetSByte();
+                    var pixelsPerUnitX = reader.GetInt32();
+                    var pixelsPerUnitY = reader.GetInt32();
+                    var unitSpecifier = reader.GetSByte();
 
-                directory.Set(PngDirectory.TagPixelsPerUnitX, pixelsPerUnitX);
-                directory.Set(PngDirectory.TagPixelsPerUnitY, pixelsPerUnitY);
-                directory.Set(PngDirectory.TagUnitSpecifier, unitSpecifier);
-                yield return directory;
+                    directory.Set(PngDirectory.TagPixelsPerUnitX, pixelsPerUnitX);
+                    directory.Set(PngDirectory.TagPixelsPerUnitY, pixelsPerUnitY);
+                    directory.Set(PngDirectory.TagUnitSpecifier, unitSpecifier);
+                    yield return directory;
+                }
             }
             else if (chunkType.Equals(PngChunkType.sBIT))
             {