New API exploration

MetadataExtractor.Tools.FileProcessor/Program.cs

@@ -26,17 +26,11 @@ internal static class Program
     {
         private static int Main(string[] args)
         {
-#if NETFRAMEWORK
-            System.Threading.Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;
-            System.Threading.Thread.CurrentThread.CurrentUICulture = CultureInfo.InvariantCulture;
-#else
             CultureInfo.CurrentCulture = CultureInfo.InvariantCulture;
             CultureInfo.CurrentUICulture = CultureInfo.InvariantCulture;
-#endif
-#if !NET35
             CultureInfo.DefaultThreadCurrentCulture = CultureInfo.InvariantCulture;
             CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.InvariantCulture;
-#endif
+
             return ProcessRecursively(args);
 //            return ProcessFileList(args);
         }

MetadataExtractor/Directory.cs

@@ -4,14 +4,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
-#if NETSTANDARD1_3 || NETSTANDARD2_0
-using System.Text;
-#endif
-#if NET35
-using DirectoryList = System.Collections.Generic.IList<MetadataExtractor.Directory>;
-#else
-using DirectoryList = System.Collections.Generic.IReadOnlyList<MetadataExtractor.Directory>;
-#endif
 
 namespace MetadataExtractor
 {
@@ -22,13 +14,12 @@ namespace MetadataExtractor
     /// <author>Drew Noakes https://drewnoakes.com</author>
     public abstract class Directory
     {
-#if NETSTANDARD1_3 || NETSTANDARD2_0
+#if NETSTANDARD2_0
         static Directory()
         {
-            Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
+            System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance);
         }
 #endif
-        internal static readonly DirectoryList EmptyList = new Directory[0];
 
         private readonly Dictionary<int, string>? _tagNameMap;
 
@@ -82,13 +73,7 @@ protected virtual bool TryGetTagName(int tagType, [NotNullWhen(returnValue: true
 
         /// <summary>Returns all <see cref="Tag"/> objects that have been set in this <see cref="Directory"/>.</summary>
         /// <value>The list of <see cref="Tag"/> objects.</value>
-        public
-#if NET35
-            IEnumerable<Tag>
-#else
-            IReadOnlyList<Tag>
-#endif
-            Tags => _definedTagList;
+        public IReadOnlyList<Tag> Tags => _definedTagList;
 
         /// <summary>Returns the number of tags set in this Directory.</summary>
         /// <value>the number of tags set in this Directory</value>
@@ -114,13 +99,7 @@ protected void SetDescriptor(ITagDescriptor descriptor)
 
         /// <summary>Used to iterate over any error messages contained in this directory.</summary>
         /// <value>The collection of error message strings.</value>
-        public
-#if NET35
-            IEnumerable<string>
-#else
-            IReadOnlyList<string>
-#endif
-            Errors => _errorList;
+        public IReadOnlyList<string> Errors => _errorList;
 
         #endregion
 

MetadataExtractor/DirectoryExtensions.cs

@@ -945,20 +945,7 @@ public static bool TryGetRational(this Directory directory, int tagType, out Rat
             }
 
             if (o is IEnumerable<string> strings)
-            {
-#if NET35
-                var sb = new StringBuilder();
-                foreach (var s in strings)
-                {
-                    if (sb.Length != 0)
-                        sb.Append(' ');
-                    sb.Append(s);
-                }
-                return sb.ToString();
-#else
                 return string.Join(" ", strings);
-#endif
-            }
 
             if (o is double d)
                 return d.ToString("0.###");