-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Automatic-Module-Name #621
Conversation
pom.xml
Outdated
@@ -147,6 +147,7 @@ | |||
<Implementation-Title>metadata-extractor</Implementation-Title> | |||
<Implementation-Vendor>Drew Noakes</Implementation-Vendor> | |||
<Implementation-Version>${project.version}</Implementation-Version> | |||
<Automatic-Module-Name>com.drew.imaging</Automatic-Module-Name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think com.drew.metadata
fits better to the artifactId and the fact that this library also supports video and audio formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm completely open to changing it to com.drew.metadata
.
Signed-off-by: Taylor Smock <[email protected]>
0d5c38b
to
dbdb8b5
Compare
Patch ping: Is there anything else I need to do? |
The issues here are my unfamiliarity with Java modules, concerns raised about minimum Java version requirements and the fact that our dependency xmp-core is not modular. With this addition, can we still compile with Java 8 and target Java 6? |
Yes, you can still compile with Java 8 and target Java 6 with this patch. All this does is modify the Manifest-Version: 1.0
Implementation-Title: metadata-extractor
+Automatic-Module-Name: com.drew.metadata
Implementation-Version: 2.18.0
Build-Jdk-Spec: 1.8
Created-By: Maven Archiver 3.4.0
Main-Class: com.drew.imaging.ImageMetadataReader
Implementation-Vendor: Drew Noakes Java 8 and lower don't use the EDIT: To add on, the |
Patch ping: Is there anything else I need to do? |
Thanks for the change and explanation. This looks good to me and no one has expressed any concerns, so I'll merge this. |
This fixes #566, and is probably preferable to #620 .