Feature/stickystyle #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drex44
reviewed
Oct 19, 2018
src/links.scss
Outdated
| &:hover { | ||
| box-shadow: 2px 8px 4px -6px hsla(0, 0%, 0%, 0.5); | ||
| } | ||
| &.yellow { |
There was a problem hiding this comment.
If you check out the highlight10, it is similar. if you change the background color then it will be the same as the one you submitted.
so instead can you please add the background color properties to the highlight10. this way, your style will be added and it won't add duplicate style to the package.
|
@drex44 , I have modified as per the comment. Please review |
|
@sareeshv Thanks for updates. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3
-Added new link styles