Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:App crash related to flutter_contacts #251

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Fix:App crash related to flutter_contacts #251

merged 2 commits into from
Sep 27, 2022

Conversation

ayyysh04
Copy link
Contributor

@ayyysh04 ayyysh04 commented Jan 6, 2022

-added contacts user-permissions in androidManifest

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

image image
Hello @ayyysh04 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

abhibhaw
abhibhaw requested changes Jan 7, 2022
View reviewed changes
scp/lib/ui/views/mentor_search/mentor_page.dart Outdated Show resolved Hide resolved
scp/lib/ui/views/mentor_search/mentor_page.dart Outdated
final result = FlutterContacts.insertContact(contact).then((value) {
print('add contact dialog closed');
}).catchError((error) {
print('pata nai bhai kya error hai');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of just printing, can we show some snackbar or any other notification widget to show user something went wrong? Or Unable to save / do the action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,we can show the snackbar same as one used in no internet connection with text "you need permission to create the contact"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview:
Screenshot_2022-01-12-21-40-54-249_in ac nitrkl scp scp

@abhibhaw abhibhaw added this to the Batch 2021-2025 Update milestone Jan 7, 2022
@abhibhaw abhibhaw linked an issue Jan 7, 2022 that may be closed by this pull request
App crash related to flutter_contacts #249
Closed
@github-actions
Copy link

image image
Hello @ayyysh04 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@ayyysh04 ayyysh04 requested a review from abhibhaw January 12, 2022 16:25
abhibhaw
abhibhaw approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks @ayyysh04 🎉

nayakastha
nayakastha approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@nayakastha nayakastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ✨

@abhibhaw abhibhaw merged commit a96f0b0 into dscnitrourkela:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayakastha nayakastha nayakastha approved these changes

@abhibhaw abhibhaw abhibhaw approved these changes

@SriramPatibanda SriramPatibanda Awaiting requested review from SriramPatibanda

Assignees

@ayyysh04 ayyysh04

Labels
None yet
Projects
None yet
Milestone
Batch 2021-2025 Update
Development

Successfully merging this pull request may close these issues.

App crash related to flutter_contacts
3 participants
@ayyysh04 @abhibhaw @nayakastha