Merge pull request #2 from du-phan/W2/input-validation-framework

Input Validation Framework
du-phan · Dec 31, 2024 · 0337874 · 0337874
2 parents 0915f3a + dfaef4e
commit 0337874
Show file tree

Hide file tree

Showing 35 changed files with 2,528 additions and 218 deletions.
diff --git a/.flake8 b/.flake8
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -45,19 +45,12 @@ jobs:
       - name: Install Dependencies
         run: poetry install
 
-      # Step 6: Run Linting (optional, remove if using pre-commit hooks)
-      - name: Lint Code with Black
-        run: poetry run black --check .
-
-      - name: Lint Code with Flake8
-        run: poetry run flake8 .
-
-      # Step 7: Run Unit Tests with Coverage
+      # Step 6: Run Unit Tests with Coverage
       - name: Run Unit Tests with Coverage
         run: |
-          poetry run pytest --maxfail=3 --disable-warnings --cov=core --cov=methodologies --cov-report=xml --cov-report=html tests/
+          poetry run pytest --maxfail=3 --disable-warnings --cov=core --cov=methodologies --cov-report=xml --cov-report=html sequestrae_engine/tests/
 
-      # Step 8: Upload Coverage Report as an Artifact (optional)
+      # Step 7: Upload Coverage Report as an Artifact (optional)
       - name: Upload Coverage Report
         uses: actions/upload-artifact@v3
         with:

diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,6 @@
 .python-version
 .vscode/
+.DS_Store
 
 # Byte-compiled / optimized / DLL files
 __pycache__/

diff --git a/.isort.cfg b/.isort.cfg
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,25 +1,18 @@
 repos:
   - repo: https://github.com/psf/black
-    rev: 24.10.0  # Replace with the version of Black you're using
+    rev: 24.10.0 # Replace with the version of Black you're using
     hooks:
       - id: black
-        args: ["--line-length=88"]
+        args: ["--line-length=100"]
 
   - repo: https://github.com/pycqa/isort
-    rev: 5.13.2  # Replace with the version of isort you're using
+    rev: 5.13.2 # Replace with the version of isort you're using
     hooks:
       - id: isort
         args: ["--profile=black"]
 
-  - repo: https://github.com/pycqa/flake8
-    rev: 7.1.1  # Replace with the version of Flake8 you're using
-    hooks:
-      - id: flake8
-        args: ["--max-line-length=88"]
-        additional_dependencies: []
-
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v5.0.0  # Replace with the version of pre-commit you're using
+    rev: v5.0.0 # Replace with the version of pre-commit you're using
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer

diff --git a/PRD.md b/PRD.md
@@ -456,7 +456,7 @@ Establish the foundational structure and implement core utilities to support met
 - Fully functional directory structure with placeholder files.
 - Implemented and tested `utilities.py`and `constants.py`
 
-## Week 2: Input Validation Framework
+## Week 2: Input Validation Framework [DONE]
 
 ### Goal
 

diff --git a/core/input_validation.py b/core/input_validation.py
diff --git a/core/utilities.py b/core/utilities.py
diff --git a/data/input_schema.json b/data/input_schema.json
diff --git a/methodologies/abstract_methodology.py b/methodologies/abstract_methodology.py
diff --git a/methodologies/factory.py b/methodologies/factory.py
diff --git a/methodologies/puro_earth_v3.py b/methodologies/puro_earth_v3.py
diff --git a/methodologies/templates/__init__.py b/methodologies/templates/__init__.py