Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RC for malicious site protection within android browser config #2566

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Dec 10, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1208947875526934/f

Description

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@CrisBarreiro CrisBarreiro requested review from a team as code owners December 10, 2024 16:25
Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Dec 10, 2024

Generated file outputs:

Time updated: Thu, 06 Feb 2025 17:15:00 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -260,8 +260,11 @@
                             "^META:https://([a-zA-Z0-9.-]+\\.)?{domain}$",
                             "^METAACCESS:https://([a-zA-Z0-9.-]+\\.)?{domain}$"
                         ]
                     }
+                },
+                "enableMaliciousSiteProtection": {
+                    "state": "internal"
                 }
             }
         },
         "androidNewStateKillSwitch": {
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -251,8 +251,11 @@
                             "^META:https://([a-zA-Z0-9.-]+\\.)?{domain}$",
                             "^METAACCESS:https://([a-zA-Z0-9.-]+\\.)?{domain}$"
                         ]
                     }
+                },
+                "enableMaliciousSiteProtection": {
+                    "state": "internal"
                 }
             }
         },
         "androidNewStateKillSwitch": {
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

cmonfortep
cmonfortep previously approved these changes Dec 12, 2024
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/browser-rc branch from f73fe93 to 6bebe41 Compare February 6, 2025 17:14
@CrisBarreiro CrisBarreiro added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit ccd7a6e Feb 13, 2025
8 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/malicious-site-protection/browser-rc branch February 13, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants