-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable testPrivacyProOnboardingCopyNov24 and removed cohorts #2656
Conversation
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Fri, 17 Jan 2025 09:41:52 GMT legacytrackers-unprotected-temporary.txt (13 more)
v3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -7001,9 +7001,9 @@
"privacyProCta": {
"state": "enabled"
},
"testPrivacyProOnboardingCopyNov24": {
- "state": "enabled",
+ "state": "disabled",
"description": "copy test in privacy pro onboarding dialog",
"targets": [
{
"localeLanguage": "en",
@@ -7013,21 +7013,21 @@
],
"cohorts": [
{
"name": "control",
- "weight": 1
+ "weight": 0
},
{
"name": "protection",
- "weight": 1
+ "weight": 0
},
{
"name": "deal",
- "weight": 1
+ "weight": 0
},
{
"name": "step",
- "weight": 1
+ "weight": 0
}
]
}
}
latestv4/android-config.json--- v4/android-config.json
+++ v4/android-config.json
@@ -6556,9 +6556,9 @@
"privacyProCta": {
"state": "enabled"
},
"testPrivacyProOnboardingCopyNov24": {
- "state": "enabled",
+ "state": "disabled",
"description": "copy test in privacy pro onboarding dialog",
"targets": [
{
"localeLanguage": "en",
@@ -6568,21 +6568,21 @@
],
"cohorts": [
{
"name": "control",
- "weight": 1
+ "weight": 0
},
{
"name": "protection",
- "weight": 1
+ "weight": 0
},
{
"name": "deal",
- "weight": 1
+ "weight": 0
},
{
"name": "step",
- "weight": 1
+ "weight": 0
}
]
}
}
v4/extension-brave-config.json (12 more)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just checking that disabling == using the control, which I think to remember it does but FYI.
Asana Task/Github Issue: https://app.asana.com/0/0/1208833556472472/f
Description
Disable
testPrivacyProOnboardingCopyNov24
feature and remove experiment cohorts.Reference