Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable testPrivacyProOnboardingCopyNov24 and removed cohorts #2656

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

nalcalag
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/0/1208833556472472/f

Description

Disable testPrivacyProOnboardingCopyNov24 feature and remove experiment cohorts.

Reference

@nalcalag nalcalag requested review from a team as code owners January 16, 2025 15:39
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Jan 16, 2025

Generated file outputs:

Time updated: Fri, 17 Jan 2025 09:41:52 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -7001,9 +7001,9 @@
                 "privacyProCta": {
                     "state": "enabled"
                 },
                 "testPrivacyProOnboardingCopyNov24": {
-                    "state": "enabled",
+                    "state": "disabled",
                     "description": "copy test in privacy pro onboarding dialog",
                     "targets": [
                         {
                             "localeLanguage": "en",
@@ -7013,21 +7013,21 @@
                     ],
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 1
+                            "weight": 0
                         },
                         {
                             "name": "protection",
-                            "weight": 1
+                            "weight": 0
                         },
                         {
                             "name": "deal",
-                            "weight": 1
+                            "weight": 0
                         },
                         {
                             "name": "step",
-                            "weight": 1
+                            "weight": 0
                         }
                     ]
                 }
             }
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -6556,9 +6556,9 @@
                 "privacyProCta": {
                     "state": "enabled"
                 },
                 "testPrivacyProOnboardingCopyNov24": {
-                    "state": "enabled",
+                    "state": "disabled",
                     "description": "copy test in privacy pro onboarding dialog",
                     "targets": [
                         {
                             "localeLanguage": "en",
@@ -6568,21 +6568,21 @@
                     ],
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 1
+                            "weight": 0
                         },
                         {
                             "name": "protection",
-                            "weight": 1
+                            "weight": 0
                         },
                         {
                             "name": "deal",
-                            "weight": 1
+                            "weight": 0
                         },
                         {
                             "name": "step",
-                            "weight": 1
+                            "weight": 0
                         }
                     ]
                 }
             }
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just checking that disabling == using the control, which I think to remember it does but FYI.

@nalcalag nalcalag added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit a5bd49d Jan 17, 2025
7 checks passed
@nalcalag nalcalag deleted the noelia/disable-privacy-pro-copy-test branch January 17, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants