Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to mitigate Android camera issues #2660

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Try to mitigate Android camera issues #2660

merged 2 commits into from
Jan 17, 2025

Conversation

tagawa
Copy link
Contributor

@tagawa tagawa commented Jan 17, 2025

Asana Task/Github Issues:

Description

Site breakage mitigation process:

Brief explanation

  • Reported URLs:

  • Problems experienced: Users reporting problems taking a photo of their ID.

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked: N/A

  • Feature being disabled: mediaPlaybackRequiresUserGesture

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@tagawa tagawa requested review from a team as code owners January 17, 2025 07:09
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Jan 17, 2025

Generated file outputs:

Time updated: Fri, 17 Jan 2025 07:46:42 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -8117,8 +8117,16 @@
                 },
                 {
                     "domain": "thrifty.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2527"
+                },
+                {
+                    "domain": "login.coinbase.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2660"
+                },
+                {
+                    "domain": "identity.docusign.net",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2660"
                 }
             ],
             "state": "enabled"
         },
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -7465,8 +7465,14 @@
                     "domain": "id.onfido.com"
                 },
                 {
                     "domain": "thrifty.com"
+                },
+                {
+                    "domain": "login.coinbase.com"
+                },
+                {
+                    "domain": "identity.docusign.net"
                 }
             ],
             "state": "enabled"
         },
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

@tagawa tagawa requested a review from laghee January 17, 2025 07:12
@tagawa tagawa changed the title Try to fix coinbase camera issues Try to fix Android camera issues Jan 17, 2025
@tagawa tagawa changed the title Try to fix Android camera issues Try to mitigate Android camera issues Jan 17, 2025
@tagawa tagawa added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 32fd7e8 Jan 17, 2025
7 checks passed
@tagawa tagawa deleted the tagawa/coinbase branch January 17, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants