Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CPM mitigation #2684

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Remove unnecessary CPM mitigation #2684

merged 1 commit into from
Jan 29, 2025

Conversation

muodov
Copy link
Member

@muodov muodov commented Jan 27, 2025

Asana Task/Github Issue: https://app.asana.com/0/1203268166580279/1209239913750151/f

Description

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@muodov muodov requested review from sammacbeth and a team as code owners January 27, 2025 12:38
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

@muodov muodov requested a review from tagawa January 27, 2025 12:38
Copy link

github-actions bot commented Jan 27, 2025

Generated file outputs:

Time updated: Tue, 28 Jan 2025 11:49:11 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (13 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -328,12 +328,8 @@
                     "domain": "voici.fr",
                     "reason": "https://github.com/duckduckgo/autoconsent/issues/66"
                 },
                 {
-                    "domain": "tfl.gov.uk",
-                    "reason": "https://github.com/duckduckgo/autoconsent/issues/68"
-                },
-                {
                     "domain": "corporatefinanceinstitute.com",
                     "reason": "CMP gets incorrectly handled / repeatedly opens tabs"
                 },
                 {
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -291,11 +291,8 @@
                 {
                     "domain": "voici.fr"
                 },
                 {
-                    "domain": "tfl.gov.uk"
-                },
-                {
                     "domain": "corporatefinanceinstitute.com"
                 },
                 {
                     "domain": "kicker.de"

sammacbeth
sammacbeth previously approved these changes Jan 28, 2025
@muodov muodov added this pull request to the merge queue Jan 28, 2025
@muodov muodov removed this pull request from the merge queue due to a manual request Jan 28, 2025
@muodov muodov added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 5c086ee Jan 29, 2025
9 checks passed
@muodov muodov deleted the tfl-remove-mitigation branch January 29, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants