Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync.seamlessAccountSwitching macOS/iOS overrides #2690

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Jan 28, 2025

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1209014391063074/f

Description

This adds a feature flag to macOS an iOS called seamlessAccountSwitching as a subfeature to sync to ship enabled. If there's an issue on launch, we'll disable it.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@graeme graeme requested review from a team as code owners January 28, 2025 14:02
@graeme graeme requested a review from quanganhdo January 28, 2025 14:02
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Jan 28, 2025

Generated file outputs:

Time updated: Tue, 28 Jan 2025 14:58:54 GMT

legacy
trackers-unprotected-temporary.txt (12 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/ios-config.json (1 more)
  • v3/ios-config.json
  • v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -7355,8 +7355,11 @@
                     "state": "enabled"
                 },
                 "level3AllowCreateAccount": {
                     "state": "enabled"
+                },
+                "seamlessAccountSwitching": {
+                    "state": "enabled"
                 }
             },
             "exceptions": [],
             "minSupportedVersion": "1.70.0"
latest
v4/android-config.json (11 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/ios-config.json (1 more)
  • v4/ios-config.json
  • v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -6717,8 +6717,11 @@
                     "state": "enabled"
                 },
                 "level3AllowCreateAccount": {
                     "state": "enabled"
+                },
+                "seamlessAccountSwitching": {
+                    "state": "enabled"
                 }
             },
             "exceptions": [],
             "minSupportedVersion": "1.70.0"

@graeme graeme added the DO NOT MERGE Don't merge this branch unless directed label Jan 28, 2025
@graeme graeme closed this Jan 28, 2025
@graeme graeme reopened this Jan 28, 2025
@graeme graeme removed the request for review from quanganhdo January 28, 2025 15:03
@graeme graeme removed the DO NOT MERGE Don't merge this branch unless directed label Jan 28, 2025
@graeme graeme requested a review from diegoreymendez January 28, 2025 16:01
@graeme graeme enabled auto-merge January 29, 2025 08:33
@graeme graeme added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit f870677 Jan 29, 2025
16 checks passed
@graeme graeme deleted the graeme/seamless-account-switching-apple-flags branch January 29, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants