Move address_optimism, optimism_attestationstation and op #6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-dude
added
ready-for-review
|
this is gonna fail again for missing ref --> source changes, but i have to step away for a bit |
aalan3
commented
Jun 4, 2024
| @@ -1,6 +1,7 @@ | |||
| {{ config( | |||
| schema = 'op_governance_optimism' | |||
| , alias = 'delegates' | |||
| , tags=['prod_exclude'] -- Due to duplicates | |||
There was a problem hiding this comment.
@kaiblade this model has duplicates which is causing tests to fail. Could you please have a look? This will be excluded in the meantime. I did some debugging here https://dune.com/queries/3796867
There was a problem hiding this comment.
@aalan3 Sorry about this. I will dedupe the model as soon as possible.
There was a problem hiding this comment.
@aalan3 @jeff-dude I have deduped the model, associated PR is #6071. Kindly review, thanks!
aalan3
force-pushed
the
daily-spellbook-op
branch
from
5b044f3 to
d73c306
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is moving another lineage to daily and adding some incremental predicates to some of the slower spells