Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dackieswap v3 on arb to dex.trades #6170

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

blanchemaria6
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

@dune-eng
Copy link

Workflow run id 9511035636 approved.

@dune-eng
Copy link

Workflow run id 9511035553 approved.

@dune-eng
Copy link

Workflow run id 9511117253 approved.

@dune-eng
Copy link

Workflow run id 9511117233 approved.

@dune-eng
Copy link

Workflow run id 9511318101 approved.

@dune-eng
Copy link

Workflow run id 9511318160 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosuke Hosuke added dbt: dex covers the DEX dbt subproject ready-for-final-review labels Jun 17, 2024
@jeff-dude
Copy link
Member

@blanchemaria6 just an fyi, it's okay to submit multiple projects per PR, especially when they are the same but different versions. we usually draw the line on one chain per PR

@jeff-dude jeff-dude merged commit e69946b into duneanalytics:main Jun 18, 2024
1 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants