refactor: adjust fork maps to avoid decoding pipeline #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hosuke
added
dune team
Hosuke
reviewed
Nov 26, 2024
Comment on lines
+85
to
+86
| , CASE when dex_map.project_name is not NULL then dex_map.project_name else concat('unknown-uni-v3-', cast(varbinary_substring(base_trades.factory_address, 1, 5) as varchar)) end as project | ||
| , CASE when dex_map.project_name is not NULL then true else false end as project_status |
There was a problem hiding this comment.
// These two lines mark if a project address is recorded in the static mapping.
…o work-on-automated-dex-trades
…o work-on-automated-dex-trades
|
can we close this PR, in favor of new one? |
|
I am not sure yet whether that approach will work - I'll close this once I am certain |
|
fairly certain this is now officially outdated and not needed, so will close |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the approach to finding fork maps to not use the decoding pipeline, aligning with our goal of moving away from the decoding infrastructure.