Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move NFT subproject into the hourly subproject #7208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

move NFT subproject into the hourly subproject #7208

wants to merge 2 commits into from

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Nov 28, 2024 •
edited
Loading

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Move NFT subproject into the hourly subproject
This does:

  • Move all NFT models into hourly
  • Remove NFT subproject boilerplate
  • adapt CI to remove NFT project setup
  • Update readme

Merge plan:

  • disable modified on hourly job
  • merge this (isolated)
  • run hourly once to update the manifest
  • disable NFT flow schedule in prefect

Follow ups:

  • monitor hourly job runtimes
  • ask platform to further clean up NFT cluster infra setup.
  • Go over and update docs and gh discussion

quick links for more information:

@0xRobin 0xRobin marked this pull request as ready for review December 2, 2024 08:02
@0xRobin 0xRobin added ready-for-review this PR development is complete, please review dune team created by dune team dbt: nft covers the NFT dbt subproject dbt: hourly covers the hourly dbt subproject labels Dec 2, 2024
@jeff-dude jeff-dude self-assigned this Dec 2, 2024
@jeff-dude jeff-dude added blocked and removed ready-for-review this PR development is complete, please review labels Dec 2, 2024
@jeff-dude
Copy link
Member

marking as blocked until we determine as a team our path forward here 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-dude jeff-dude Awaiting requested review from jeff-dude

At least 1 approving review is required to merge this pull request.

Assignees

@jeff-dude jeff-dude

Labels
blocked dbt: hourly covers the hourly dbt subproject dbt: nft covers the NFT dbt subproject dune team created by dune team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xRobin @jeff-dude