Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zkswap_finance_v3 to trades #7212

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

ZkSwapFinance
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Add zkSwapFinance exchange v3 to trades.
More info at: https://docs.zkswap.finance/contracts-and-audits/smart-contracts/zkswap-exchange
[...]


quick links for more information:

Copy link

github-actions bot commented Nov 29, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Hosuke Hosuke self-assigned this Nov 29, 2024
@Hosuke Hosuke added the dbt: dex covers the DEX dbt subproject label Nov 29, 2024
@ZkSwapFinance
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 29, 2024
@ZkSwapFinance
Copy link
Contributor Author

@0xRobin @jeff-dude

@Hosuke Hosuke added the in review Assignee is currently reviewing the PR label Dec 1, 2024
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosuke Hosuke added ready-for-final-review and removed in review Assignee is currently reviewing the PR labels Dec 1, 2024
@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Dec 1, 2024
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the patience, i will be looking to do merges tomorrow

@jeff-dude jeff-dude merged commit cc584ea into duneanalytics:main Dec 3, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Dec 3, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

GitPOAP: 2024 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants