Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup_economics v3 #7626

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

rollup_economics v3 #7626

wants to merge 17 commits into from

Conversation

lorenz234
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

After getting feedback from the other rollup_economic wizards we agreed to change the spell to use a mapping rather than inline filters: dune.growthepie.l2economics_mapping

this should reduce runtime and also enable future additions such as rent paid to Celestia and other altDAs.


quick links for more information:

@github-actions github-actions bot marked this pull request as draft February 5, 2025 15:14
@github-actions github-actions bot added WIP work in progress dbt: hourly covers the hourly dbt subproject labels Feb 5, 2025
@lorenz234
Copy link
Contributor Author

lorenz234 commented Feb 7, 2025

After receiving feedback from the other rollup_economic wizards, we agreed to modify the spell to use a mapping instead of inline filters. This version also allows for future extensions, such as rent payments to Celestia and other altDAs. The mapping can be found in this table: dune.growthepie.l2economics_mapping and is actively maintained by the growthepie team here: https://github.com/growthepie/gtp-dna/tree/main/economics_da

Some dashboards will break due to changes in names and columns—this has been communicated to the relevant individuals.

One dbt question remains:
Ideally, we want this spell to run incrementally every hour. However, it should only re-run in full if dune.growthepie.l2economics_mapping is updated (tracked by detecting hash changes), as historical data would then need to be refreshed. Since I'm relatively new to dbt, I’d appreciate it if someone from the Dune team could double-check the current setup. If it works as intended, it should significantly reduce runtime compared to executing the full query every time.

@lorenz234 lorenz234 marked this pull request as ready for review February 7, 2025 15:01
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: hourly covers the hourly dbt subproject ready-for-review this PR development is complete, please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant