Skip to content

deps: remove unnecessary dependencies #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

7-zete-7
Copy link
Contributor

@7-zete-7 7-zete-7 commented Aug 19, 2025

I suggest removing the following dependencies:

  • acl
  • gettext

These dependencies are not used or have no useful functionality.

See #819

@maxhelias maxhelias requested a review from dunglas August 19, 2025 14:20
@dunglas
Copy link
Owner

dunglas commented Aug 19, 2025

IIRC, the file binary is used by Symfony (HttpFoundation?) to guess the mime type of uploaded files.

I'm not sure about the other tools. We used to use acl in the Docker entrypoint, but it may not be the case anymore.

@7-zete-7
Copy link
Contributor Author

7-zete-7 commented Aug 20, 2025

@dunglas you are right. Found usage of the file binary in the Symfony\Component\Mime\FileBinaryMimeTypeGuesser class (migrated from HttpFondation). Will undo removal of that package.

Thanks for pointing this out!

@danut007ro
Copy link

If git is removed then this should also solve #824

@7-zete-7
Copy link
Contributor Author

@danut007ro I agree. But I'm not sure if git can be a mandatory dependency for some Composer scenarios.

Maybe there is some information why git might be needed for Composer and whether this dependency is important?

@7-zete-7
Copy link
Contributor Author

@zpi12lmm yes, and this PR removes them.

These lines do not carry any useful payload within this template. The container always starts as root by default (and some entrypoint lines will only work as root), so there is no need to grant file permissions to www-data and the current user (the same root).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants