This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
sanitize article content to fix stored xss #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've discovered a stored Cross-Site Scripting (XSS) vulnerability in the projects/react_blog:
Vulnerability Details:
Version Affected: All versions
Severity: [High/Critical – Stored XSS can have a significant impact. Adjust based on your assessment]
Description: The vulnerability allows malicious attacks to inject scripts through a direct network request. Once embedded, any user's browser viewing the article will execute the malicious script
Steps to Reproduce:
Send a direct POST request (bypassing the user interface) to /addArticle with payload content containing the malicious script.
After the article is successfully created or edited, any user's browser that views the article will run the malicious script.
Suggested Fix or Mitigation:
Server-side: When creating the article, it's essential to sanitize the user's input (content) before processing it to ensure malicious scripts are neutralized.
Client-side: Before displaying the article's content using dangerouslySetInnerHtml, ensure that the description is sanitized using libraries like DOMPurify to prevent script execution.
I've already fixed and tested this issue, and have submitted a pull request with the necessary changes. Please review and merge my pull request at your earliest convenience to resolve this vulnerability. Thanks!