Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lumen compatibility if facades are disabled #195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Lumen compatibility if facades are disabled #195

wants to merge 2 commits into from

Conversation

chrisschaetzlein
Copy link
Contributor

These changes will allow using this package with Lumen with disabled facades. Tested with the latest 5.5, not sure about older versions.

@chrisschaetzlein
Add Lumen without facades compatibility
1b31167 
Remove facades usage for firing events
@chrisschaetzlein
Add Lumen without facades compatibility
ab0e734 
Remove facades usage for getting the default Validator instance
@dwightwatson
Copy link
Owner

Unfortunately this breaks all the tests - any idea on how to get the suite back to green when using app()?

@chrisschaetzlein
Copy link
Contributor Author

Hmm... according to the error reported by Travis:
PHP Fatal error: Call to undefined function Watson\Validating\app()
I assume that the test runner is not aware of the global app() helper function that Lumen (and afaik Laravel too) provides?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisschaetzlein @dwightwatson