Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

PR: Extend Demo #5

Merged
merged 43 commits into from
May 30, 2022
Merged

PR: Extend Demo #5

merged 43 commits into from
May 30, 2022

Conversation

nelsonic
Copy link
Member

The extended demo is working fine on localhost:
gitea-demo-homepage-updated

https://gitea-server.fly.dev/demo-org/hello-world
gitea-repo-updaetd

But deploying it to Fly.io is proving more challenging than I had hoped.
Opened a dedicated issue for the ssh key setup: #4 on Fly.io

@nelsonic nelsonic added help wanted Extra attention is needed in-progress An issue or pull request that is being worked on by the assigned person labels May 18, 2022
@nelsonic nelsonic self-assigned this May 18, 2022
nelsonic added 14 commits May 19, 2022 00:29
@nelsonic
attempt to rename app #3
1d53566
@nelsonic
attempt to borrow config from https://github.com/fly-apps/hello_elixi…
c783ce0 
…r/blob/main/Dockerfile
@nelsonic
add git to RUNNER_IMAGE #3
756fc1c
@nelsonic
remove locale lines from Dockerfile #3
6166c44
@nelsonic
attempt to run the full gitea demo with git clone, write, commit & pu…
a6969e6 
…sh ... #3
@nelsonic
System.cmd("cat", ["/home/nobody/.ssh/id_ed25519"]) #3
5356a7e
@nelsonic
attempt to use build.args
47a4c54
@nelsonic
add more advanced demo code so that we can test on Fly.io
65d1941
@nelsonic
temporarily revert demo to simple version so we can ssh into the serv…
ba6c83e 
…er ...
@nelsonic
attempt RUN mkdir -p /home/nobody/.ssh/
d49f1f5
@nelsonic
attempt RUN ssh-keyscan -H gitea-server.fly.dev > /home/nobody/.ssh/k…
c4be857 
…nown_hosts #4
@nelsonic
attempt COPY keys/id_ed25519 /home/nobody/.ssh/ in DOCKERFILE #4
184314b
@nelsonic
attempt RUN chown nobody /home/nobody/.ssh/ #4
52fba1d
@nelsonic
RUN chmod 600 /home/nobody/.ssh/id_ed25519 #4
86ea24b
nelsonic
nelsonic commented May 20, 2022
View reviewed changes
Dockerfile Outdated
# copy the keys you've created on your machine
COPY keys/id_ed25519 /home/nobody/.ssh/
# add know host gitea server
RUN ssh-keyscan -H gitea-server.fly.dev > /home/nobody/.ssh/known_hosts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab the RUN ssh-keyscan -H gitea-server.fly.dev > /home/nobody/.ssh/known_hosts is already present in the Dockerfile... #4 (comment)

@codecov
Copy link

codecov bot commented May 27, 2022 •
edited
Loading

Codecov Report

Merging #5 (e6a355c) into main (a74af72) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines            8        27   +19     
=========================================
+ Hits             8        27   +19
Impacted Files Coverage Δ
lib/app_web/controllers/page_controller.ex 100.00% <100.00%> (ø)
lib/app_web/router.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74af72...e6a355c. Read the comment docs.

@nelsonic
Copy link
Member Author

Boom! Passing!! 💥

@nelsonic nelsonic mentioned this pull request May 27, 2022
Closed
4 tasks
@nelsonic
Copy link
Member Author

When reviewing this PR, visit the Fly.io App: https://gitea-demo.fly.dev/
phoenix-gitea-demo-on-fly io

And the gitea server repo:
https://gitea-server.fly.dev/demo-org/hello-world
gitea-demo-file-updated

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed help wanted Extra attention is needed in-progress An issue or pull request that is being worked on by the assigned person labels May 27, 2022
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic May 27, 2022
@nelsonic nelsonic requested a review from SimonLab May 27, 2022 13:46
@nelsonic
Copy link
Member Author

@SimonLab I've done a quick (self) proof-read of https://github.com/dwyl/gitea-demo/blob/extend-demo/part2.md and made a few updates. I feel this PR is now in a reviewable state. Thanks! 🙏

@nelsonic nelsonic mentioned this pull request May 27, 2022
Closed
@SimonLab SimonLab added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels May 28, 2022
@nelsonic
Copy link
Member Author

Very keen to test the CI/CD (specifically deploying the ssh key to Fly.io) so that we can use it in the project. 🤞

SimonLab
SimonLab approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonLab SimonLab merged commit e278625 into main May 30, 2022
@SimonLab SimonLab deleted the extend-demo branch May 30, 2022 10:38
@nelsonic nelsonic mentioned this pull request May 30, 2022
Closed
@nelsonic
Copy link
Member Author

Follow-up deployment debugging required: #16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
in-review Issue or pull request that is currently being reviewed by the assigned person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab