fix deploys #1369
fix deploys #1369
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@coderabbitai create an issue for creating a lint to make sure the start scripts in |
|
@dyc3, the issue for creating a lint rule to ensure the start scripts in Analysis chain@dyc3, based on the
Given this information, I will proceed to create an issue on GitHub to request the creation of a lint rule ensuring these start scripts reference valid paths. Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Locate and display the contents of the `package.json` file to understand the start scripts.
fd package.json --exec cat {}
Length of output: 12104 Script: #!/bin/bash
# Create a GitHub issue for adding a lint rule to validate start script paths
gh issue create --title "Add lint rule for validating start script paths" --body "We need to ensure that the start scripts in `package.json` across various packages reference valid paths. This includes scripts in the `ott-server` and the root `package.json` files. Implementing a lint rule would help maintain the integrity of these scripts and prevent runtime errors due to incorrect paths.
Affected start scripts:
- `ott-server`: `node --experimental-specifier-resolution=node --loader ts-node/esm app.ts`
- Root package: `yarn workspace ott-server start`
This issue was requested in PR https://github.com/dyc3/opentogethertube/pull/1369." --repo dyc3/opentogethertube
Length of output: 1199 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1369 +/- ##
===========================================
Coverage 54.1663% 54.1663%
===========================================
Files 158 158
Lines 24650 24650
Branches 1437 1437
===========================================
Hits 13352 13352
Misses 11241 11241
Partials 57 57 ☔ View full report in Codecov by Sentry. |
Passing run #1066 ↗︎
Details:
Review all test suite changes for PR #1369 ↗︎ |
|||||||||||||||
Passing run #1067 ↗︎
Details:
Review all test suite changes for PR #1369 ↗︎ |
|||||||||||||||
* Revert "fix `start-lean` (#1373)" This reverts commit bab537a. * Revert "switch `ott-server` to import `ott-common` instead of referencing the relative file path (#1356)" This reverts commit dc22e4e. * Revert "fix deploys (#1369)" This reverts commit cfc0304. * Revert "fix deploys for real (#1371)" This reverts commit 4634b71.
No description provided.