partial ripgrep support #1448
Open
partial ripgrep support #1448
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is ripgrep already available in our docker image? |
It is available in the standard debian/kali repo. |
|
ok, I will build a new docker-base image for further testing. The current results are very cool! |
m-1-k-3
added
enhancement
|
I did a quick benchmark yesterday with the original EMBA master branch vs the ripgrep PR: Looks as we do not get any speedup of ripgrep. Can you also reproduce these results? |
m-1-k-3
reviewed
Jan 29, 2025
| @@ -58,7 +58,7 @@ IF20_nvd_feed() { | |||
| git clone --depth 1 -b main https://github.com/EMBA-support-repos/EPSS-data.git external/EPSS-data || ( echo "Could not install EMBA component NIST EPSS data feed" && exit 1 ) | |||
| fi | |||
|
|
|||
| if [[ $(grep -l -E "cpe.*busybox:" external/nvd-json-data-feeds/* -r 2>/dev/null | wc -l) -gt 18 ]]; then | |||
| if [[ $(rg -l "cpe.*busybox:" external/nvd-json-data-feeds/* 2>/dev/null | wc -l) -gt 18 ]]; then | |||
There was a problem hiding this comment.
I would not recommend using rg in the installer as we need to install it on the host first
m-1-k-3
reviewed
Jan 29, 2025
| @@ -38,7 +38,7 @@ for STRING_ENTRY in "${STRING_ENTRY_ARR[@]}"; do | |||
|
|
|||
| echo "[*] Testing SBOM entry ${COMPONENT//::}" | |||
|
|
|||
| if [[ "$(grep -h "cpe.*${COMPONENT//::}:" external/nvd-json-data-feeds/* -r | wc -l 2>/dev/null)" -gt 0 ]]; then | |||
| if [[ "$(rg -I -N "cpe.*${COMPONENT//::}:" external/nvd-json-data-feeds/* | wc -l 2>/dev/null)" -gt 0 ]]; then | |||
There was a problem hiding this comment.
This is a helper script for the host and I would not recommend using rg in such a script as we need to install it on the host first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It uses ripgrep to search for regex.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)? If possible add a screenshot.
It is considerably faster.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: