-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Sandbox routing: Use Redis for client-proxy DNS instead of local map. #245
Draft
jaytaylor
wants to merge
1
commit into
main
Choose a base branch
from
jay/redis-dns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaytaylor
force-pushed
the
jay/redis-dns
branch
from
January 17, 2025 00:51
5dda45e
to
f56e3f7
Compare
jaytaylor
force-pushed
the
jay/redis-dns
branch
3 times, most recently
from
January 17, 2025 01:12
7c35766
to
39ce0fb
Compare
jaytaylor
force-pushed
the
jay/redis-dns
branch
from
January 17, 2025 01:16
39ce0fb
to
1b0c1bc
Compare
jakubno
requested changes
Jan 17, 2025
jaytaylor
force-pushed
the
jay/redis-dns
branch
2 times, most recently
from
January 17, 2025 01:28
c942f6b
to
ea157fd
Compare
jaytaylor
force-pushed
the
jay/redis-dns
branch
from
January 17, 2025 01:29
ea157fd
to
e9aa15d
Compare
jaytaylor
force-pushed
the
jay/redis-dns
branch
from
January 17, 2025 01:32
e9aa15d
to
a705c0f
Compare
jaytaylor
force-pushed
the
jay/redis-dns
branch
from
January 17, 2025 01:33
a705c0f
to
8067eeb
Compare
The PR looks good! |
ValentaTomas
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API: Sandbox routing:
Use Redis for client-proxy DNS instead of local map.
It also cleans up logging a bit to be more consistent and informative about activity.
✨
Description by Callstackai
This PR refactors the DNS handling in the API to use Redis for client-proxy DNS instead of a local map. It also improves logging consistency and adds a Redis job specification.
Diagrams of code changes
Files Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.hcl
,.tf
. See list of supported languages.