Fix tapchg starpoint with table #2566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…star point in powerfactory. This combination is not possible, also not in powerfactory
…le' into fix_tapchg_starpoint_with_table # Conflicts: # pandapower/converter/powerfactory/pp_import_functions.py
…d an error if tap_dependency_table column is not available
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2566 +/- ##
===========================================
- Coverage 75.52% 75.52% -0.01%
===========================================
Files 288 288
Lines 34935 34938 +3
===========================================
+ Hits 26385 26387 +2
- Misses 8550 8551 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@hilbrich, please add a comment to the changelog. |
|
@pawellytaev As discussed I will wait for some insights of the tap_at_starpoint. I would be happy if you can share your insights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tap changer at star point is not possible when having tap_dependency_table. I updated the logic and also documentation accordingly.