Implementing device level IO metrics. #109
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 45.26% 44.47% -0.79%
==========================================
Files 54 54
Lines 4012 4101 +89
Branches 478 484 +6
==========================================
+ Hits 1816 1824 +8
- Misses 2065 2144 +79
- Partials 131 133 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Xiaoxi Chen <[email protected]>
We can use it as a simple benchmark to see performance of a drive after passing device interface Signed-off-by: Xiaoxi Chen <[email protected]>
Signed-off-by: Xiaoxi Chen <[email protected]>
src/include/iomgr/io_device.hpp
Outdated
| case DriveOpType::WRITE: | ||
| HISTOGRAM_OBSERVE(*m_metrics, write_lat, dur); | ||
| HISTOGRAM_OBSERVE(*m_metrics, write_size, iocb->size); | ||
| LOGINFO("write, size {}, lat {}", iocb->size, dur); |
There was a problem hiding this comment.
Change to debug or trace log after you've finished debugging? Otherwise it would be too much log, right.
There was a problem hiding this comment.
yes this is more for debugging ATM. will lower them to trace later
src/include/iomgr/io_device.hpp
Outdated
| case DriveOpType::READ: | ||
| HISTOGRAM_OBSERVE(*m_metrics, read_lat, dur); | ||
| HISTOGRAM_OBSERVE(*m_metrics, read_size, iocb->size); | ||
| LOGINFO("read, size {}, lat {}", iocb->size, dur); |
src/include/iomgr/io_device.hpp
Outdated
| case DriveOpType::FSYNC: | ||
| HISTOGRAM_OBSERVE(*m_metrics, fsync_lat, dur); | ||
| HISTOGRAM_OBSERVE(*m_metrics, fsync_size, iocb->size); | ||
| LOGINFO("fsync, size {}, lat {}", iocb->size, dur); |
Signed-off-by: Xiaoxi Chen <[email protected]>
| @@ -178,6 +178,7 @@ io_device_ptr UringDriveInterface::open_dev(const std::string& devname, drive_ty | |||
| iodev->devname = devname; | |||
| iodev->creator = iomanager.am_i_io_reactor() ? iomanager.iofiber_self() : nullptr; | |||
| iodev->dtype = dev_type; | |||
| iodev->enable_metrics(devname); | |||
There was a problem hiding this comment.
In some environment where kernel version is not above 5.x, iomgr will fall back to AIO interface during boot time. Right now most of our env including test env is above 5.x, since iomgr is open source and to be friendly to community(who may running on old kernel ver), do you also want to add it in AIO and SPDK's open_dev to enable metrics?
Interfaces are opt-in as the observe_metrics need to be called from interface.