Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide IOManagerExecutor for use with folly::Futures library. #52

Closed
wants to merge 2 commits into from

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Sep 12, 2023

No description provided.

@szmyd szmyd marked this pull request as draft September 12, 2023 15:08
@szmyd szmyd changed the title Remove grpc dependency; not used currently. Provide IOManagerExecutor for use with folly::Futures library. Sep 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (7e8d2cf) 0.00% compared to head (62f85ac) 45.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #52       +/-   ##
===========================================
+ Coverage        0   45.24%   +45.24%     
===========================================
  Files           0       54       +54     
  Lines           0     4003     +4003     
  Branches        0      474      +474     
===========================================
+ Hits            0     1811     +1811     
- Misses          0     2053     +2053     
- Partials        0      139      +139     
Files Coverage Δ
src/include/iomgr/iomgr.hpp 79.54% <100.00%> (ø)
src/lib/iomgr.cpp 60.46% <30.00%> (ø)
src/test/test_fiber_shared_mutex.cpp 0.00% <0.00%> (ø)

... and 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd
Copy link
Collaborator Author

szmyd commented Sep 12, 2023

This is in no way close to ready yet; using it for conversation only at this moment.

@szmyd szmyd self-assigned this Oct 24, 2023
@szmyd szmyd added this to the MileStone3.11 milestone Oct 24, 2023
@szmyd szmyd linked an issue Oct 24, 2023 that may be closed by this pull request
@szmyd szmyd modified the milestones: MileStone3.11, MileStone4.1 Dec 21, 2023
@szmyd szmyd closed this Feb 13, 2024
@szmyd szmyd deleted the folly_executor branch July 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide folly::Executor from IOManager
2 participants