Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cpr to 1.10.5 #59

Closed
wants to merge 1 commit into from
Closed

Conversation

JacksonYao287
Copy link
Contributor

@JacksonYao287 JacksonYao287 commented Nov 18, 2023

this PR is to resolve the following ERROR:

ERROR: Conflict in cpr/1.10.4:
'cpr/1.10.4' requires 'libcurl/8.2.1' while 'prometheus-cpp/1.1.0' requires 'libcurl/8.4.0'.
To fix this conflict you need to override the package 'libcurl' in your root package.

Screenshot 2023-11-18 at 20 49 04

@JacksonYao287 JacksonYao287 added the bug Something isn't working label Nov 18, 2023
@JacksonYao287 JacksonYao287 added this to the MileStone3.11 milestone Nov 18, 2023
@JacksonYao287 JacksonYao287 requested a review from szmyd November 18, 2023 12:50
@JacksonYao287 JacksonYao287 self-assigned this Nov 18, 2023
@JacksonYao287 JacksonYao287 removed the bug Something isn't working label Nov 19, 2023
@szmyd
Copy link
Collaborator

szmyd commented Nov 20, 2023

The libcurl dependency has already been resolved by bumping libcurl. this change shouldn't be required.

@JacksonYao287
Copy link
Contributor Author

The libcurl dependency has already been resolved by bumping libcurl. this change shouldn't be required.

@szmyd
i can not build the latest master branch in my local environment, since cpr and prometheus requires different version of libcurl, which cause a conflict

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e23f80) 45.16% compared to head (66a0c12) 45.27%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   45.16%   45.27%   +0.11%     
==========================================
  Files          54       54              
  Lines        3999     4000       +1     
  Branches      478      478              
==========================================
+ Hits         1806     1811       +5     
  Misses       2059     2059              
+ Partials      134      130       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants