Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unblock real drive testing with hdd #83

Merged
merged 2 commits into from
May 21, 2024
Merged

unblock real drive testing with hdd #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e05af9
unblock real drive testing with hdd
yamingk May 17, 2024
bb2f7bc
fix log
yamingk May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

class IOMgrConan(ConanFile):
name = "iomgr"
version = "11.3.1"
version = "11.3.2"

homepage = "https://github.com/eBay/IOManager"
description = "Asynchronous event manager"
Expand Down
5 changes: 3 additions & 2 deletions src/lib/interfaces/drive_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ static std::string get_raid_hdd_vendor_model_megcli() {
#endif

static std::string get_raid_hdd_vendor_model() {
return ""; // see this issue for more details: https://github.com/eBay/IOManager/issues/82
#ifdef MEGACLI_OPTION_ENABLED
return get_raid_hdd_vendor_model_megcli();
#else
Expand Down Expand Up @@ -216,7 +217,7 @@ drive_type DriveInterface::get_drive_type(const std::string& dev_name) {
dtype = it->second;
} else {
dtype = detect_drive_type(dev_name);
LOGINFOMOD(iomgr, "Drive={} is detected to be drive_type={}", dev_name, dtype);
LOGINFO("Drive={} is detected to be drive_type={}", dev_name, dtype);
s_dev_type.insert({dev_name, dtype});
}

Expand Down Expand Up @@ -432,7 +433,7 @@ std::error_code KernelDriveInterface::sync_write(IODevice* iodev, const char* da
++resubmit_cnt;
}
if (sisl_unlikely(written_size != size)) {
LOGWARN("Error during write offset={} write_size={} written_size={} errno={} fd={}", offset, size, written_size,
LOGWARN("Error during write offset={} size={} written_size={} errno={} fd={}", offset, size, written_size,
errno, iodev->fd());
return std::error_code{((errno == 0) ? ERANGE : errno), std::generic_category()};
} else {
Expand Down
Loading