feat: Add EbayChip and EbayChipsCombobox components #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriqueLimas
requested review from
aaron-nance,
ArtBlue,
agliga and
darkwebdev
🦋 Changeset detectedLatest commit: 1f79b51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HenriqueLimas
force-pushed
the
chips-combobox
branch
from
333bda9 to
dfe31d2
Compare
are we supposed to add the items that we select? |
|
@shpandian we should I will check what issue is causing this on storybook |
shpandian
approved these changes
Mar 24, 2025
HenriqueLimas
added a commit
that referenced
this pull request
Mar 24, 2025
* feat: Add EbayChip and EbayChipsCombobox components * update storybook link * fix storybook links * export ComboboxOption from chips-combobox also * docs: improve chips-combobox stories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marko: ebay-chip and ebay-chips-combobox
Storybook:
ebay-chip
ebay-chips-combobox
Fixes #310 #426