Added support for ACLs on port groups. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @anfredette . LGTM! A minor comment is that it would be better to split the fixes such as for the problem when external_ids == nil in separate commits. Let me know if you'd like to do that. |
|
I agree. I’ll split it out.
Thanks,
Andre
…On Sun, Jan 3, 2021 at 5:21 PM Han Zhou ***@***.***> wrote:
Thanks @anfredette <https://github.com/anfredette> . LGTM!
A minor comment is that it would be better to split the fixes such as for
the problem when external_ids == nil in separate commits. Let me know if
you'd like to do that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#122 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHY7X3QKMLWM2U3JRHXDDTSYD3Y3ANCNFSM4VGJWSRA>
.
|
anfredette
force-pushed
the
pg-acls3
branch
3 times, most recently
from
86f34b8 to
62e7a78
Compare
|
I've updated this PR as follows:
|
hzhou8
reviewed
Jan 7, 2021
|
Per Han's request above, and discussion on Slack, I've changed the port group ACL APIs to use the PG name instead of the PG UUID. NOTE: I've kept this change as a separate commit to facilitate reviews. After I get the thumbs up, I will squash the last two commits. |
hzhou8
approved these changes
Jan 11, 2021
- Using ovn-nbctl acl-add/del as a model, an entityType parameter was added to the API which could be either PORT_GROUP or LOICAL_SWITCH. - In order to maintain backward compatibility of the existing APIs, a new set of APIs called ACLAddEntity/ACLDelEntity/ACLListEntity were added. - Note: both versions of the APIs call the same underlying implementation functions. Also made a minor optimization suggested by vtolstov on pr-117. Signed-off-by: Andre Fredette <[email protected]>
|
This PR has been reworked on top of PR-125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ACLs on port groups.
the API which could be either PORT_GROUP or LOICAL_SWITCH.
of APIs called ACLAddEntity/ACLDelEntity/ACLListEntity were added.
implementation functions.
Also made a minor optimization suggested by vtolstov on pr-117.
Signed-off-by: Andre Fredette [email protected]