Generic client blob #216
Merged
Generic client blob #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 63.61% 63.77% +0.15%
==========================================
Files 72 72
Lines 4332 4400 +68
Branches 547 557 +10
==========================================
+ Hits 2756 2806 +50
- Misses 1332 1344 +12
- Partials 244 250 +6
|
yamingk
reviewed
Feb 6, 2024
yamingk
reviewed
Feb 6, 2024
yamingk
reviewed
Feb 6, 2024
yamingk
reviewed
Feb 6, 2024
raakella1
force-pushed
the
generic_client_blob
branch
from
75622a4 to
2426064
Compare
szmyd
reviewed
Feb 8, 2024
added 5 commits
February 9, 2024 11:34
…est case to the sisl::io_blob version of the grpc client future
raakella1
force-pushed
the
generic_client_blob
branch
from
94c21be to
1993fcb
Compare
yamingk
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
call_unaryrpc to generic grpc client which acceptssisl::io_blob_list_tand returns a semi future ofclient_response_ptr. The user can access the grpc client response message in the form ofsisl::io_blobbyclient_response_ptr->response_blob()and not worry about serialize and deserialize and keeping track of the buffer allocations.The main changes are in rpc_client. The generic_service changes are just splitting them into cpp and header file and can be ignored