Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow copyable GenericClientResponse structure and enhanced testing for inline/multi slices #231

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Allow copyable GenericClientResponse structure and enhanced testing for inline/multi slices #231

merged 1 commit into from
Mar 22, 2024

Conversation

hkadayam
Copy link
Contributor

No description provided.

@hkadayam hkadayam requested review from raakella1 and szmyd March 22, 2024 22:10
szmyd
szmyd approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that familiar with grpc::Slice so will need to trust what's being done is correct. Otherwise 👍

include/sisl/grpc/rpc_client.hpp Show resolved Hide resolved
raakella1
raakella1 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@hkadayam hkadayam merged commit c3b8844 into eBay:master Mar 22, 2024
5 checks passed
@hkadayam hkadayam deleted the copy_slice_buffer branch March 22, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raakella1 raakella1 raakella1 approved these changes

@szmyd szmyd szmyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkadayam @szmyd @raakella1