Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add backtrace for debug builds #234

Merged
merged 1 commit into from
May 13, 2024
Merged

add backtrace for debug builds #234

merged 1 commit into from
May 13, 2024

Conversation

raakella1
Copy link
Contributor

The functionality to send signal to all threads and log backtrace was disabled previously due to it resulting in stuck threads while collecting the backtrace. This change enables it only for the debug builds.

@raakella1 raakella1 requested review from szmyd and hkadayam May 13, 2024 20:09
szmyd
szmyd approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build control (Debug/vs. Other) appears correct. I didn't verify the actual functionality as I assume it is the same as what we had before (which kinda worked as pointed out in the comment).

@raakella1
Copy link
Contributor Author

The build control (Debug/vs. Other) appears correct. I didn't verify the actual functionality as I assume it is the same as what we had before (which kinda worked as pointed out in the comment).

Yes, I just copied the code we had before. I tested out by running the logging_example which worked as expected for the debug and test builds.

@raakella1 raakella1 merged commit 3ed9693 into eBay:master May 13, 2024
5 checks passed
@raakella1 raakella1 deleted the debug_backtrace branch May 13, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmyd szmyd szmyd approved these changes

@hkadayam hkadayam Awaiting requested review from hkadayam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raakella1 @szmyd