Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed unused storybook files (and percy workflow) #2461

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Oct 1, 2024

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Removed all storybook compiled code. This is unused since we output to _site when we build for deployment.
  • Also removed storybook workflow file

Note

No changeset needed since this won't need to be released

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue

@agliga agliga requested review from ArtBlue and LuLaValva October 1, 2024 18:20
@agliga agliga self-assigned this Oct 1, 2024
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: ab4b485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ArtBlue
Copy link
Contributor

ArtBlue commented Oct 2, 2024

Is this supposed to target master? Do we need a changset?

It looks like the checks are failing because of:

npm error Missing script: "deploy:only"

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good locally. As long as we figure out the error in the checks and have a changeset, his looks ready.

@agliga agliga force-pushed the storybook branch 2 times, most recently from 277b012 to ede7d66 Compare October 2, 2024 19:47
@agliga agliga merged commit 9d93be8 into 18.4.0 Oct 4, 2024
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
@agliga agliga deleted the storybook branch December 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants