Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Test and Reconnect to Data Store #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikeflynn
Copy link

I've been using this library as part of a service and I've seen it lose the Redis connection, so I added a simple method on the store (and the related interfaces) to query and reset the connection as needed.

This could apply to any other data store over the network, but could also just be a nil function for stores that don't need a connection reset.

…of the redis (or other data store) connections for long running processes.
@eaigner
Copy link
Owner

eaigner commented Feb 27, 2016

Thanks for the PR. Wouldn't it be better though to let shield automatically reconnect instead of exposing a TestConnection to the user?

@mikeflynn
Copy link
Author

Yup, I had a similar thought...but I ended up not going that route as we would have to have a new setting to tweak how often it should check/reset and would add a thread to check for the reset timer even for applications that were just running in a one off and didn't need it. In the end, I figured I would just offload that logic to the apps that decided they wanted it, but it could certainly go the other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants