-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic CI for MacOS and Windows #307
Merged
RobertPincus
merged 35 commits into
earth-system-radiation:makepath-cmake
from
makepath-alex:cmake-mac-win-dev
Dec 11, 2024
Merged
Added basic CI for MacOS and Windows #307
RobertPincus
merged 35 commits into
earth-system-radiation:makepath-cmake
from
makepath-alex:cmake-mac-win-dev
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@makepath-alex It seems like many of these changes in the PR are already in the |
It was not updated. Should be better now :) |
makepath-alex
force-pushed
the
cmake-mac-win-dev
branch
2 times, most recently
from
December 6, 2024 09:34
4ff2ae2
to
e80e13f
Compare
…cript for simplicity
RobertPincus
reviewed
Dec 9, 2024
makepath-alex
force-pushed
the
cmake-mac-win-dev
branch
from
December 9, 2024 15:25
419aef1
to
d8afcd7
Compare
makepath-alex
force-pushed
the
cmake-mac-win-dev
branch
from
December 9, 2024 15:47
0758bbc
to
d9578ed
Compare
RobertPincus
approved these changes
Dec 11, 2024
RobertPincus
merged commit Dec 11, 2024
3d99501
into
earth-system-radiation:makepath-cmake
43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current basic workflow is to use conda
It has been tested on Windows/Linux/Mac and WSL.
Unfortunately still on some systems we encounter errors, which I am trying to figure out as they emerge, but in most cases the workflow works as expected.
Steps to configure and build:
Create conda dev environment:
Set environment variables:
Configure build using Ninja. We use ninja becuase it is multiplatform and thus the setup is identical on Windows, Linux and Mac. Feel free to replace the genertor with another one of your choince, for example
-G "Unix Makefiles"
Note that we configure CMAKE for release build
-DCMAKE_BUILD_TYPE=Release
.Alternatively if you want a debug configuration, change the work Release with Debug and debug flags like
-g
will automatically be added to the compiler.The build configuration will be stored in
build
folder and then you can either go there and build the source using your generator's default instruments, or you can build it with Cmake. I prefer telling CMake to build it for me, this way it's the same command line that I can use on all OS and it's agnostic of the generator I use, be it Ninja, Makefiles or MS Visual StudioFinally, if ENABLE_TESTS option was selected, you can also run the tests using
Important note.
Once CMake has been configured, all the build-rated files will be located in the
build
folder.If you want to do small reconfigurations, you don't need to delete the entire build folder and start the process from scratch, you can simply go to the build folder and run simething like
This will update the existing configuration to disable tests and switch to Debug mode.
After that you need to recompile as usual.