Improvements needed for the new onboarding tutorial #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idodod
approved these changes
Jul 12, 2023
| RUN cat /globe.txt | ||
| RUN echo "Hello, $name!" > /hello.txt | ||
| CMD ["cat", "/hello.txt"] | ||
| SAVE ARTIFACT /hello.txt AS LOCAL hello.txt |
There was a problem hiding this comment.
Probably a longshot but possibly a user might lose a file they did not expect to lose when running this?
There was a problem hiding this comment.
I think anything with earthly in it should be fine (but if we want to be extra safe we can use a pre-generated random string (so that cache won't bust) -
e.g hello-from-earthly-technologies.txt, hello-earthly-349875894357.txt
There was a problem hiding this comment.
I'll merge as is for now, and I might fix this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.