Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib}[foss/2023b] HeFFTe v2.4.1 #21912

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 26, 2024

(created using eb --new-pr)

@boegel boegel added the update label Nov 26, 2024
@boegel
Copy link
Member Author

boegel commented Nov 26, 2024

@boegelbot please test @ generoso
CORE_CNT=16

Copy link

Updated software HeFFTe-2.4.1-foss-2023b.eb

Diff against HeFFTe-2.4.0-foss-2023b.eb

easybuild/easyconfigs/h/HeFFTe/HeFFTe-2.4.0-foss-2023b.eb

diff --git a/easybuild/easyconfigs/h/HeFFTe/HeFFTe-2.4.0-foss-2023b.eb b/easybuild/easyconfigs/h/HeFFTe/HeFFTe-2.4.1-foss-2023b.eb
index 63cedb53c4..7d38225fc5 100644
--- a/easybuild/easyconfigs/h/HeFFTe/HeFFTe-2.4.0-foss-2023b.eb
+++ b/easybuild/easyconfigs/h/HeFFTe/HeFFTe-2.4.1-foss-2023b.eb
@@ -1,7 +1,7 @@
 easyblock = 'CMakeMake'
 
 name = 'HeFFTe'
-version = '2.4.0'
+version = '2.4.1'
 
 homepage = 'https://icl.utk.edu/fft'
 description = "Highly Efficient FFT for Exascale (HeFFTe) library"
@@ -10,7 +10,7 @@ toolchain = {'name': 'foss', 'version': '2023b'}
 
 source_urls = ['https://github.com/icl-utk-edu/heffte/archive/']
 sources = ['v%(version)s.tar.gz']
-checksums = ['02310fb4f9688df02f7181667e61c3adb7e38baf79611d80919d47452ff7881d']
+checksums = ['de2cf26df5d61baac7841525db3f393cb007f79612ac7534fd4757f154ba3e6c']
 
 builddependencies = [
     ('CMake', '3.27.6'),
@@ -20,6 +20,11 @@ build_shared_libs = True
 
 configopts = "-DHeffte_ENABLE_FFTW=ON -DFFTW_ROOT=$EBROOTFFTW -DHeffte_ENABLE_CUDA=OFF -DHeffte_ENABLE_MKL=OFF"
 
+# allow oversubscription of MPI ranks to cores, tests are hardcoded to use up to 12 MPI ranks
+pretestopts = "export OMPI_MCA_rmaps_base_oversubscribe=true && "
+
+runtest = 'test'
+
 sanity_check_paths = {
     'files': ['lib/libheffte.%s' % SHLIB_EXT],
     'dirs': ['include', 'lib/cmake/Heffte', 'share/heffte/examples'],
Diff against HeFFTe-1.0-foss-2020a.eb

easybuild/easyconfigs/h/HeFFTe/HeFFTe-1.0-foss-2020a.eb

diff --git a/easybuild/easyconfigs/h/HeFFTe/HeFFTe-1.0-foss-2020a.eb b/easybuild/easyconfigs/h/HeFFTe/HeFFTe-2.4.1-foss-2023b.eb
index a843130f7b..7d38225fc5 100644
--- a/easybuild/easyconfigs/h/HeFFTe/HeFFTe-1.0-foss-2020a.eb
+++ b/easybuild/easyconfigs/h/HeFFTe/HeFFTe-2.4.1-foss-2023b.eb
@@ -1,23 +1,30 @@
 easyblock = 'CMakeMake'
 
 name = 'HeFFTe'
-version = '1.0'
+version = '2.4.1'
 
 homepage = 'https://icl.utk.edu/fft'
 description = "Highly Efficient FFT for Exascale (HeFFTe) library"
 
-toolchain = {'name': 'foss', 'version': '2020a'}
+toolchain = {'name': 'foss', 'version': '2023b'}
 
-source_urls = ['https://bitbucket.org/icl/heffte/get/']
+source_urls = ['https://github.com/icl-utk-edu/heffte/archive/']
 sources = ['v%(version)s.tar.gz']
-checksums = ['0902479fb5b1bad01438ca0a72efd577a3529c3d8bad0028f3c18d3a4935ca74']
+checksums = ['de2cf26df5d61baac7841525db3f393cb007f79612ac7534fd4757f154ba3e6c']
 
-builddependencies = [('CMake', '3.16.4')]
+builddependencies = [
+    ('CMake', '3.27.6'),
+]
 
 build_shared_libs = True
 
 configopts = "-DHeffte_ENABLE_FFTW=ON -DFFTW_ROOT=$EBROOTFFTW -DHeffte_ENABLE_CUDA=OFF -DHeffte_ENABLE_MKL=OFF"
 
+# allow oversubscription of MPI ranks to cores, tests are hardcoded to use up to 12 MPI ranks
+pretestopts = "export OMPI_MCA_rmaps_base_oversubscribe=true && "
+
+runtest = 'test'
+
 sanity_check_paths = {
     'files': ['lib/libheffte.%s' % SHLIB_EXT],
     'dirs': ['include', 'lib/cmake/Heffte', 'share/heffte/examples'],

@boegel boegel added this to the 4.x milestone Nov 26, 2024
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21912 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21912 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14768

Test results coming soon (I hope)...

- notification for comment with ID 2500772221 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/84502a52452c164c4944e2b86ff1bc02 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 26, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21912 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21912 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5342

Test results coming soon (I hope)...

- notification for comment with ID 2500825307 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/485b3390723d8e81ba47c1956dfa8b2c for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 26, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3164.skitty.os - Linux RHEL 9.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.9.18
See https://gist.github.com/boegel/a49439df96b08e8e7528a82e1f8ebc27 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 28, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
aarch64-neoverse-v1-node1.int.aws-rocky88-202310.eessi.io - Linux Rocky Linux 8.10, AArch64, ARM UNKNOWN (neoverse_v1), Python 3.6.8
See https://gist.github.com/boegel/9e4d40d51bd60a44d69fabbe9294cca8 for a full test report.

@boegel boegel requested a review from ocaisa November 29, 2024 08:52
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 58b09e4 into easybuilders:develop Nov 29, 2024
10 checks passed
@boegel boegel deleted the 20241126141326_new_pr_HeFFTe241 branch December 1, 2024 17:07
@boegel boegel modified the milestones: 4.x, release after 4.9.4 Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants