Skip to content

Commit

Permalink
TODO: coding style and nbdkit code sharing ideas
Browse files Browse the repository at this point in the history
Capture some longer-term ideas from the subthread at
<https://listman.redhat.com/archives/libguestfs/2023-February/030685.html>:

  [Libguestfs] [libnbd PATCH v3 01/29]
  use space consistently in function and function-like macro invocations

(Message-Id: <[email protected]>.)

Signed-off-by: Laszlo Ersek <[email protected]>
  • Loading branch information
lersek committed Feb 22, 2023
1 parent b5101fb commit 46d60f8
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,12 @@ testsuite:
result in a binary that always fails for trying to use a contended
port. Rewriting these tests to use pick-a-port.c for a dynamic
choice would be safer.

Coding style:
- consider replacing "#if defined (macro)" with "#if defined macro", or
even just "#ifdef macro"; for shorter lines
- investigate automatic code formatting tools (such a tool could be run
in "check mode" in CI)

Code sharing with nbdkit (header files, etc):
- investigate a git submodule

0 comments on commit 46d60f8

Please sign in to comment.