Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to nlohmann json #21

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Switch to nlohmann json #21

merged 4 commits into from
Jan 24, 2025

Conversation

tomjnixon
Copy link
Member

No description provided.

firthm01
firthm01 reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@firthm01 firthm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than readme needs updating for deps. Pointed EPS to this branch and it seems happy with it too.

@tomjnixon
Copy link
Member Author

Thanks for checking, and spotting the missing documentation, i'll get that sorted.

@firthm01 firthm01 requested a review from rsjbailey January 23, 2025 17:08
@firthm01
Copy link
Collaborator

@rsjbailey - happy to merge this if you are, then we can point the EPS at this for the release.

@firthm01 firthm01 marked this pull request as ready for review January 23, 2025 17:53
@firthm01 firthm01 merged commit 6127e89 into main Jan 24, 2025
1 check passed
@firthm01 firthm01 deleted the switch_to_nlohmann_json branch January 24, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firthm01 firthm01 firthm01 left review comments

@rsjbailey rsjbailey Awaiting requested review from rsjbailey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjnixon @firthm01