Issues #30 / #21: Support additional speaker setups #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Just to let you know the cartesian speaker position stuff has now been merged into the master branch of libadm |
…ons. Also apply these extensions to protobuf messaging types and DirectSpeakers plugin combobox.
…ers plugin combo-box to clean up the displayed layouts.
… to own fork, based on rjtaylor's catesian-speakerposition, in order to implement additional functions to render all layouts present in Common Definitions.
…FormatId fields in SPEAKER_SETUPS and pass these to libadm. This works around the table-lookup in libadm, where the tables aren't complete and therefore not all setups worked.
…e SPEAKER_SETUPS by AudioPackFormat, because the layout names can be ambivalent.
… Fix failed case scene_gains_calculator_tests.cpp by adapting the hard-coded Setup index to match the changes of the SPEAKER_SETUPS structure.
…tesian speaker position stuff has been merged into libadm master.
merktj
force-pushed
the
ial_additional_speaker_setups
branch
from
5b14876 to
5af89fd
Compare
|
I've switched my fork to be based on libadm's master branch now and created a pull request for the features that need to be integrated into libadm. ear-production-suite/.gitmodules Line 3 in cc74951 |
|
merged as #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30 and #21 .
In order to add new speaker layouts, the static SPEAKER_SETUPS, as well as Protobuf messages had to be extented and new fields were added to resolve ambivalent naming. Because the lookup-tables in libadm are incomplete, the handling was changed to create object when rendering in the scene plugin directly using AudioPack/TrackFormatIds.
For the moment, I've replaced libadm by my own fork which is based on the currently used fork by @rsjtaylor. As soon as the additions can be integrated there, the submodule link has to be changed back to that fork:
ear-production-suite/.gitmodules
Line 3 in cc74951